----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32813/#review79054 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java <https://reviews.apache.org/r/32813/#comment128093> Can we store 60L * 1000L as a constant? ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java <https://reviews.apache.org/r/32813/#comment128094> On the order of how many elements can staleAerts contain? Dozen, hundred, more? - Alejandro Fernandez On April 6, 2015, 7:23 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32813/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 7:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, Jeff Sposetti, and > Tom Beerbower. > > > Bugs: AMBARI-10348 > https://issues.apache.org/jira/browse/AMBARI-10348 > > > Repository: ambari > > > Description > ------- > > Due to alerts being run on distributed platforms - we have problem wherein if > alert is scheduled to run on a host that goes down - its not obvious to > customer that alerts are not running and something is wrong. We need to do 2 > things: > > 1. Generate an alert when not heard from Ambari Agent for quite sometime > 2. Fire alerts which havent been run for quite sometime - saying they havent > been run due to host not responding. > > Seems like 2 new alerts are required, both of which being "Server Side" > (which is a new concept). > > - Ambari Server will need to maintain information about the last heartbeat > from a host and produce alerts when a heartbeat has not been received. A new > {{@AmbariService}} can handle this. > > - Ambari Server will need to periodically check the last timestamp of all > enabled alert instances and determine if the alert has not run within a > certain period of time. A new {{@AmbariService}} can handle this. > > We should utilize the alerts.json defined outside the stack since this > affects hosts and alert instants and is not bound to a cluster. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/alerts/AgentHeartbeatAlertRunnable.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java > 506f911 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertGroupService.java > a1f1ab4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertHistoryService.java > f1855f0 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertNoticeService.java > 1922e2e > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertService.java > a916c4c > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertTargetService.java > 2a2ecdf > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > e87cd57 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHostListener.java > d478bf5 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java > c54baa2 > > ambari-server/src/main/java/org/apache/ambari/server/metadata/AgentAlertDefinitions.java > af70a51 > > ambari-server/src/main/java/org/apache/ambari/server/metadata/AmbariServiceAlertDefinitions.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java > fd63166 > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java > 43fb450 > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java > c8b78a0 > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/SourceType.java > 49119d4 > > ambari-server/src/main/java/org/apache/ambari/server/state/services/AmbariServerAlertService.java > PRE-CREATION > ambari-server/src/main/resources/alerts.json 753c29c > > ambari-server/src/test/java/org/apache/ambari/server/alerts/AgentHeartbeatAlertRunnableTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/alerts/StaleAlertRunnableTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > a9eff8c > > ambari-server/src/test/java/org/apache/ambari/server/events/MockEventListener.java > e9261fa > > ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java > 22a9830 > ambari-web/app/controllers/main/alerts/definition_configs_controller.js > 82844ae > ambari-web/app/mappers/alert_definitions_mapper.js c4679c1 > > Diff: https://reviews.apache.org/r/32813/diff/ > > > Testing > ------- > > New tests written to cover new Runnables. > > mvn clean test > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 15:42 min > [INFO] Finished at: 2015-04-03T11:51:16-04:00 > [INFO] Final Memory: 45M/622M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
