-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33064/#review79777
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml
<https://reviews.apache.org/r/33064/#comment129340>

    This means we'll need to add Phoenix to the Rolling Upgrade orchestration. 
Take a look at upgrade-2.2.xml to find out where it goes.



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
<https://reviews.apache.org/r/33064/#comment129339>

    We should use named imports. This makes it easier to find which module 
things come from.



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
<https://reviews.apache.org/r/33064/#comment129342>

    Use named imports.



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
<https://reviews.apache.org/r/33064/#comment129343>

    In a kerberized cluster, will first need to kinit before starting or 
stopping. Is that going to go in this patch or a future one?



ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
<https://reviews.apache.org/r/33064/#comment129344>

    Should probably check that the exists first.


- Alejandro Fernandez


On April 10, 2015, 8:58 p.m., nick dimiduk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33064/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 8:58 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-9993
>     https://issues.apache.org/jira/browse/AMBARI-9993
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Per JIRA
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml
>  1032024 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  98f0473 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33064/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nick dimiduk
> 
>

Reply via email to