----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33092/#review79778 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/33092/#comment129347> Should set this as a final static constant somewhere. ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java <https://reviews.apache.org/r/33092/#comment129348> Should we leave display name as non-nullable? The schema still has the column as NOT NULL ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql <https://reviews.apache.org/r/33092/#comment129349> Do we need to make similar changes in the UpgradeCatalog? - Alejandro Fernandez On April 10, 2015, 10:05 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33092/ > ----------------------------------------------------------- > > (Updated April 10, 2015, 10:05 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Myroslav Papirkovskyy, and Sumit Mohanty. > > > Bugs: AMBARI-10445 > https://issues.apache.org/jira/browse/AMBARI-10445 > > > Repository: ambari > > > Description > ------- > > - On cluster create, copy cluster & host level widgets from stack to DB. > - On service create, copy service level widgets from stack to DB. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > 613d5f5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 5959327 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > c226823 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 2724a97 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java > 53734aa > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java > eedde92 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java > 87ae723 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetDAO.java > c85e255 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAO.java > 1d05acc > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java > d383a62 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java > 820e3e0 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/WidgetLayout.java > d730adf > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/WidgetLayoutInfo.java > d3d317d > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 2ae970c > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8db0e32 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql ca27989 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > e1f9d6c > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 87820ca > > ambari-server/src/test/resources/stacks/OTHER/2.0/services/HBASE/widgets.json > 705c3eb > > Diff: https://reviews.apache.org/r/33092/diff/ > > > Testing > ------- > > Unit test passed. > > > Thanks, > > Sid Wagle > >
