> On April 17, 2015, 10:04 p.m., Jayush Luniya wrote: > > > > Gautam Borad wrote: > @jayush, will make the necessary changes once Ranger KMS supports > creation of pid file.
@Gautam, can you file a JIRA for that work and mark the comment as "Dropped". Also, I dont see any unit tests for the new service. Can you add unit tests as well? - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33264/#review80544 ----------------------------------------------------------- On April 20, 2015, 2:16 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33264/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 2:16 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit > Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-10523 > https://issues.apache.org/jira/browse/AMBARI-10523 > > > Repository: ambari > > > Description > ------- > > Ranger KMS should be available as a service to be installed/managed from > Ambari. > User will be able to add a new service "Ranger KMS" and there will be one > Server component in the service. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-acls.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/service_check.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json > ead3dd4 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER_KMS/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/33264/diff/ > > > Testing > ------- > > Tested adding the Ranger KMS on an CentOS6 instance. > > > Thanks, > > Gautam Borad > >
