> On April 17, 2015, 10:11 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py, > > line 251 > > <https://reviews.apache.org/r/33227/diff/2/?file=931738#file931738line251> > > > > HDP stack specific logic in common-services is not ideal if we want to > > make this a common-service for different vendors. At the very least we > > should check the stack name along with stack version.
We might want not to hardcode properties in Python, but to move them to site.xml and use stack inheritance logic here to have different sets of properties in different stacks. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33227/#review80545 ----------------------------------------------------------- On April 16, 2015, 2:31 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33227/ > ----------------------------------------------------------- > > (Updated April 16, 2015, 2:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit > Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-10503 > https://issues.apache.org/jira/browse/AMBARI-10503 > > > Repository: ambari > > > Description > ------- > > Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit > logs. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py > abde3f2 > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py > 7626de8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 2a13337 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > 9413d8e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > e5f9679 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 54de4a6 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py > b3baf32 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > c069fc5 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > ac2bc0a > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > c1f365c > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > abc51d5 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py > a3cc587 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/33227/diff/ > > > Testing > ------- > > Tested with an ambari instance running ranger and a solr server running on > one of the node. > Checked the audit logs and they were getting generated for the plugins. ( > tested hdfs/hive/hbase/knox ) > > > Thanks, > > Gautam Borad > >
