----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33432/#review81211 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On April 22, 2015, 8:29 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33432/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 8:29 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-10648 > https://issues.apache.org/jira/browse/AMBARI-10648 > > > Repository: ambari > > > Description > ------- > > With this patch: > 1. Heatmap pages are API (stack) driven. > 2. All the heatmaps that were previously hardcoded on UI are now retrieved > from API. In addition other heatmap definitions are added in the stack. > 3. Dashboard->Heatmap page also has service specific heatmaps (same as in > earlier releases of Ambari) > 4. Last visited heatmap widget on the specific heatmap page by the user is > saved in the widget layout and shown as default heatmap on navigation to the > heatmap page next time. (As opposed to the current behavior where the 1st > heatmap in the hardcoded list is always shown by default on the heatmap page) > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json > 8920843 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json > 622ee03 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json > a9e233f > ambari-server/src/main/resources/stacks/HDP/2.0.6/widgets.json 7935750 > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/widgets.json > 1212133 > ambari-web/app/assets/data/widget_layouts/HBASE/default_dashboard.json > 9374ab0 > ambari-web/app/assets/data/widget_layouts/all_heatmaps.json PRE-CREATION > ambari-web/app/assets/test/tests.js 27aaf95 > ambari-web/app/controllers.js 0777187 > ambari-web/app/controllers/main/charts/heatmap.js 02ccbed > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric.js > c4a7b95 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_cpuWaitIO.js > 35bb947 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_dfs.js > 100a65e > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_dfs_bytesread.js > 0d28eb0b > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_dfs_byteswritten.js > 9306241 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_dfs_gctime.js > c39393f > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_dfs_memHeapUsed.js > 18ae47b > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_diskspaceused.js > 403e034 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_hbase.js > 9b1fc4a > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_hbase_compactionqueue.js > 09cb300 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_hbase_memstoresize.js > a4eed4e > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_hbase_readrequest.js > 6f914e6 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_hbase_regions.js > a2c2c11 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_hbase_writerequest.js > f81ab63 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_memoryused.js > 335966d > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js > 20de918 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_yarn.js > f60075d > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_yarn_ResourceUsed.js > f0ee406 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_yarn_gctime.js > 10efe65 > > ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_yarn_memHeapUsed.js > 762c0bf > ambari-web/app/controllers/main/service/info/heatmap.js 467b8d7 > ambari-web/app/controllers/main/service/info/summary.js 882eade > ambari-web/app/messages.js 5da43f9 > ambari-web/app/mixins.js a272c24 > ambari-web/app/mixins/common/widget_mixin.js e59fb20 > ambari-web/app/mixins/common/widgets/widget_mixin.js PRE-CREATION > ambari-web/app/mixins/common/widgets/widget_section.js PRE-CREATION > ambari-web/app/models/widget.js 3ef265c > ambari-web/app/routes/main.js 81f5171 > ambari-web/app/templates/common/widget/heatmap_widget.hbs PRE-CREATION > ambari-web/app/templates/main/charts/heatmap.hbs 89a9a37 > ambari-web/app/templates/main/charts/heatmap_dropdown.hbs PRE-CREATION > ambari-web/app/templates/main/service/info/heatmap_dropdown.hbs > PRE-CREATION > ambari-web/app/utils/ajax/ajax.js 366cf5d > ambari-web/app/utils/heatmap.js d8672b1 > ambari-web/app/views.js b0e1cac > ambari-web/app/views/common/widget/heatmap_widget_view.js PRE-CREATION > ambari-web/app/views/main/charts/heatmap.js 5147123 > ambari-web/app/views/main/charts/heatmap/heatmap_host.js 6f54221 > ambari-web/app/views/main/charts/heatmap/heatmap_rack.js 35653cd > ambari-web/app/views/main/service/info/heatmap_view.js fb6a2d1 > ambari-web/app/views/main/service/info/summary.js 60734f1 > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_cpuWaitIO_test.js > 6f46539 > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_dfs_bytesread_test.js > cebf41d > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_dfs_byteswritten_test.js > 240802e > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_dfs_test.js > 06d62c2 > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_diskspaceused_test.js > 312c9c6 > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_hbase_test.js > a1f0325 > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_memoryused_test.js > 8886d8a > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun_test.js > f23d02c > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_test.js > fb134e4 > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_yarn_ResourceUsed_test.js > 4d8a847 > > ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_yarn_test.js > d8744cd > ambari-web/test/controllers/main/charts/heatmap_test.js 399a34c > > Diff: https://reviews.apache.org/r/33432/diff/ > > > Testing > ------- > > tested on a live cluster > Verified that all unit test passes with the patch > > > Thanks, > > Jaimin Jetly > >
