----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33466/#review81307 -----------------------------------------------------------
Ship it! It seems like some clean up can be done (but maybe not related to this ticket). Other than that, it looks good to me. ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json <https://reviews.apache.org/r/33466/#comment131630> This is good, but we might want to consider pulling this identity out to the service-level and applying updates as needed for the compoent. This file has a lot of redundancy in it. But as is, it should work fine. ambari-server/src/test/python/stacks/2.0.6/configs/secured.json <https://reviews.apache.org/r/33466/#comment131634> `phoenix.queryserver.keytab.file` should probably be added somewhere as well. ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json <https://reviews.apache.org/r/33466/#comment131633> `phoenix.queryserver.keytab.file` should probably be added somewhere as well. - Robert Levas On April 23, 2015, 12:47 a.m., nick dimiduk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33466/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 12:47 a.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-10680 > https://issues.apache.org/jira/browse/AMBARI-10680 > > > Repository: ambari > > > Description > ------- > > Enables QPS support on kerberized clusters. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json > 67664a9 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > eafcd89 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_queryserver_jaas.conf.j2 > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 3f4aad9 > ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json ea57e66 > > Diff: https://reviews.apache.org/r/33466/diff/ > > > Testing > ------- > > > Thanks, > > nick dimiduk > >
