----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33698/#review82054 -----------------------------------------------------------
Thanks for writing unit tests! ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml <https://reviews.apache.org/r/33698/#comment132696> Does Atlas have a component name in hdp-select? E.g., hdp-select status atlas ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py <https://reviews.apache.org/r/33698/#comment132697> Used name imports since it's easier to debug ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py <https://reviews.apache.org/r/33698/#comment132698> sys and deepcopy are not used ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py <https://reviews.apache.org/r/33698/#comment132699> Use named imports ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py <https://reviews.apache.org/r/33698/#comment132700> Will eventually need it to be included in RU. So it will need its definition in upgrade-2.3.xml ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py <https://reviews.apache.org/r/33698/#comment132701> Use named imports ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py <https://reviews.apache.org/r/33698/#comment132703> Use named imports. regex is not used here. ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py <https://reviews.apache.org/r/33698/#comment132702> Use named imports ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py <https://reviews.apache.org/r/33698/#comment132704> This is not always the case, need it to be [200, 300) ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py <https://reviews.apache.org/r/33698/#comment132705> Use named imports ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py <https://reviews.apache.org/r/33698/#comment132706> Security needs to be accounted for, i.e., kinit in start and stop commands. - Alejandro Fernandez On April 29, 2015, 9:37 p.m., Jonathan Maron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33698/ > ----------------------------------------------------------- > > (Updated April 29, 2015, 9:37 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, > and Sid Wagle. > > > Bugs: https://issues.apache.org/jira/browse/AMBARI-10853 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853 > > > Repository: ambari > > > Description > ------- > > This is the initial commit for a service definition for Apache Atlas. It > provides the files necessary to install, configure, and start the Atlas > Metadata Server. There will be follow on commits for supporting: > > 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has > yet to be leveraged and tested but is in the package for completeness/place > holder). > 2) UI enhancements - configuration panels, quick links, metrics (an > alerts.json is included for completeness but not tested) > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json > 93be128 > ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22 > > Diff: https://reviews.apache.org/r/33698/diff/ > > > Testing > ------- > > Functional testing was performed using an Amabri installation on a local > VM-based network. In addition, unit tests for configure, start, and stop > have been written. > > > Thanks, > > Jonathan Maron > >
