> On May 6, 2015, 9:29 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py, > > line 64 > > <https://reviews.apache.org/r/33835/diff/1/?file=949374#file949374line64> > > > > If creating the file fails, ExecuteHadoop(clean_and_create_file_cmd, > > ...) will not raise an error. > > It uses retries, so I can remove the ls and instead make the command > > fail on error (after retries are exhausted). > > Andrew Onischuk wrote: > It will raise Fail, in raises fail on non-zero return code, which > typically hadoop binary returns. Why won't it raise fail?
and for sure it will fail once retries are exhausted. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33835/#review82735 ----------------------------------------------------------- On May 5, 2015, 1:23 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33835/ > ----------------------------------------------------------- > > (Updated May 5, 2015, 1:23 a.m.) > > > Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-10920 > https://issues.apache.org/jira/browse/AMBARI-10920 > > > Repository: ambari > > > Description > ------- > > Pig Service check should log the output of calling pigSmoke.sh > Further, it should indicate whether the input password file was copied to > HDFS and give the file appropriate permissions (644) > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py > 9de30ed > ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py > df30085 > ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py > f930780 > > Diff: https://reviews.apache.org/r/33835/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Total run:691 > Total errors:0 > Total failures:0 > OK > > Deployed a cluster with HDP 2.2 and Pig Service Check passed. > > > Thanks, > > Alejandro Fernandez > >
