> On May 6, 2015, 5:50 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java, > > lines 52-54 > > <https://reviews.apache.org/r/33914/diff/2/?file=951583#file951583line52> > > > > Can this be a float? It will be a pain to put one "in the middle" in > > the future. For example, pretend we have: > > 1, 2, 3, 4, 5 ... 100 > > > > Now, to replace 2, we have to go back and re-number 3-100. But if it's > > a float, we just need to make 1.1 and leave the others? > > Jonathan Hurley wrote: > We can, but there are inherent issues with using floats for comparison. > 2.0 != 2.0 ... we'd need to do some kind of precision 2.0 - 2.0 <= .0000001 > kind of thing which gets weird. If you can think of a good way to compare > floats for this purpose, then I can change it. > > Alejandro Fernandez wrote: > Use Strings, > A < B < C > and can then use AA or AB or AC for granularity. And I don't think we'll > have more than 26 group levels > > Nate Cole wrote: > I'm ok with ints, we probably won't have more than a dozen or so anyway > per group. Floats seem to have less of an issue with those crazy decimals > when you use, say, 1.1f, 1.0f etc. Doubles on the other hand are the worst! > I t
That's an interesting idea. But after looking into it a bit more, I think I'll be able to use Float.compareTo for this purpose. I'll take a crack at it. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33914/#review82742 ----------------------------------------------------------- On May 6, 2015, 5:49 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33914/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 5:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower. > > > Bugs: AMBARI-10976 > https://issues.apache.org/jira/browse/AMBARI-10976 > > > Repository: ambari > > > Description > ------- > > Added the upgrade checks for HDP 2.2 to 2.3, including some that were missed > for 2.2 to 2.2+. > > Added an annotation mechanism to define order in which checks are grouped and > run. > > > Diffs > ----- > > ambari-project/pom.xml 378a998 > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > 1816ce8 > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > b00d6fb > > ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java > e4dd0e6 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java > cf9e4ae > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java > 2c5ff28 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java > 0ea5d08 > > ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java > 14ec2c1 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesDecommissionCheck.java > 7497c2f > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java > 0ae5c46 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java > 36526e3 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java > e43e4fb > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java > 41735b4 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java > e0696fa > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java > a56f35d > > ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 3994a7b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java > 3460423 > ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java > abaf8e7 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/checks/UpgradeCheckOrderTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheckTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33914/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
