----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33938/#review82814 -----------------------------------------------------------
Ship it! Ship It! - Andrew Onischuk On May 7, 2015, 9:59 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33938/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 9:59 a.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-10786 > https://issues.apache.org/jira/browse/AMBARI-10786 > > > Repository: ambari > > > Description > ------- > > It seems ambari_sequences.sequence_value was renamed in 1.7.0 but 1.5.0, > 1.6.0 and 1.6.1 Catalogs all expect column name to be sequence_value > The rename should be idempotent, this code is doomed to fail even when > running upgrade command more than once. > org.apache.ambari.server.upgrade.UpgradeCatalog170#renameSequenceValueColumnName > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java > 98ac89f > > Diff: https://reviews.apache.org/r/33938/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
