> On May 7, 2015, 6:33 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml, > > lines 383-387 > > <https://reviews.apache.org/r/33957/diff/1/?file=952611#file952611line383> > > > > Hmm, by the time this gets executed, it will be too late. I'm forced > > to add this because it's also a prerequisite check. Could likely remove > > this step from the process.
Are you sure about this? This property didn't exist in HDP 2.2. Why would it need to be a pre-req? - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33957/#review82932 ----------------------------------------------------------- On May 7, 2015, 6:23 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33957/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 6:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-11006 > https://issues.apache.org/jira/browse/AMBARI-11006 > > > Repository: ambari > > > Description > ------- > > HDP 2.2 to 2.3 upgrade pack changes. Additionally, changes the configure task > to be able to take defaults when transferring properties which was needed by > YARN and MapR. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > a812169 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 1f921c9 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 225cc63 > > ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/GLUSTERFS/configuration/hadoop-env.xml > bce6b53 > > ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/HIVE/configuration/webhcat-site.xml > a7caae4 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml > cb641d6 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-plugin-properties.xml > 93035d1 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > ecd55db > > Diff: https://reviews.apache.org/r/33957/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
