[ 
https://issues.apache.org/jira/browse/AMBARI-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535647#comment-14535647
 ] 

Hudson commented on AMBARI-10997:
---------------------------------

SUCCESS: Integrated in Ambari-trunk-Commit #2554 (See 
[https://builds.apache.org/job/Ambari-trunk-Commit/2554/])
AMBARI-10997. Improve Error Handling - hive view (alexantonenko) (hiveww: 
http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=642fd46cbf5d8e232007b487ceef0618aa2dd9e7)
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/services/notify-test.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/helpers/tb-helper.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/progress-widget-test.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/extended-input-test.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/query-tabs.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/open-queries.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/udfs/UDFResourceProvider.java
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/query-tabs.hbs
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/integration/database-test.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/styles/query-tabs.scss
* contrib/views/hive/src/main/resources/ui/hive-web/app/mixins/filterable.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/application.hbs
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/ServiceFormattedException.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/SharedObjectsFactory.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js
* contrib/views/hive/src/main/java/org/apache/ambari/view/hive/BaseService.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/OperationHandleController.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/utils/functions.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/adapters/application.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visual-explain.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/column-filter-widget-test.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/views/notification.js
* 
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/ATSParserTest.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParser.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/resources/FileResourceService.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/templates/query-tabs.hbs
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/number-range-widget.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/visual-explain.hbs
* contrib/views/hive/src/main/resources/ui/hive-web/tests/helpers/api-mock.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/number-range-widget-test.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/collapsible-widget-test.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryResourceProvider.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/serializers/database.js
* 
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/AggregatorTest.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/modal-widget.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ProgressRetriever.java
* contrib/views/hive/src/main/resources/ui/hive-web/package.json
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/routes/index/saved-query.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/OperationHandleControllerFactory.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/PersonalCRUDResourceManager.java
* contrib/views/hive/src/main/resources/view.xml
* contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/notify.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/styles/mixins.scss
* contrib/views/hive/pom.xml
* contrib/views/hive/src/main/resources/ui/hive-web/app/routes/application.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/tabs-wiget-test.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/collapsible-widget.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/history.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/templates/tez-ui.hbs
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/no-bubbling-test.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/udfs/UDFService.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/services/notify.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/job.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/visual-explain-test.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/expander-widget-test.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/typeahead-widget-test.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/IOperationHandleResourceManager.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/views/visual-explain.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/rm/RMRequestsDelegateImpl.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/views/messages.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/query-editor.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/components/query-tabs.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/typeahead-widget.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/notify-widget.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobResourceProvider.java
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/column-filter-widget.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/adapters/application.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/progress-widget.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/results.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/expander-widget.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/date-range-widget-test.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/templates/messages.hbs
* contrib/views/hive/src/main/resources/ui/hive-web/app/styles/vars.scss
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/OperationHandleResourceManager.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/helpers/code-helper.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/popover-widget-test.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/rm/RMRequestsDelegate.java
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/select-widget-test.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/settings.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/styles/dropdown-submenu.scss
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/query-editor-test.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/logs.js
* contrib/views/hive/src/main/resources/ui/hive-web/tests/blanket-options.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/index-test.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/IATSParser.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/utils/dag-rules.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/alert-message-widget.js
* contrib/views/hive/src/main/resources/ui/hive-web/tests/index.html
* contrib/views/hive/src/main/resources/ui/hive-web/app/helpers/path-binding.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/tez-ui.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/helpers/preformatted-string.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/resources/FileResourceResourceProvider.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/rm/RMParser.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ConnectionController.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/helpers/log-helper.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index.hbs
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/job-progress.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/helpers/date-binding.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/settings-test.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/date-range-widget.js
* contrib/views/hive/src/main/resources/ui/hive-web/.gitignore
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/progress-widget.hbs
* contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/messages.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/views/message.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/udfs.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java
* contrib/views/hive/src/main/resources/ui/hive-web/app/helpers/all-uppercase.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/popover-widget.js
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegate.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/rm/RMParserFactory.java
* 
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/TezVertexId.java
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/explain.js
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/styles/notifications.scss
* 
contrib/views/hive/src/main/resources/ui/hive-web/app/components/panel-widget.js
* contrib/views/hive/src/main/resources/ui/hive-web/app/router.js


> Improve Error Handling - hive view
> ----------------------------------
>
>                 Key: AMBARI-10997
>                 URL: https://issues.apache.org/jira/browse/AMBARI-10997
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-views
>    Affects Versions: 2.1.0
>            Reporter: Erik Bergenholtz
>            Assignee: Antonenko Alexander
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-10997.patch
>
>
> We should handle the most common cases better than how we do it today. For 
> example
> * Syntax Error
> * Non Existent Table Selected
> * Non Existent Column Selected
> * Bad Query
> In the above cases we get a certain exception back from Hive and should be 
> able to show a more meaningful message back to the user (as well as the 
> underlying exception). We should continue to allow the stack trace to be 
> shown, but this should not be the default behavior.
> In the cases where we don't "understand" the cause of the error, we should 
> continue to use the existing behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to