> On Май 8, 2015, 6:02 п.п., Sid Wagle wrote: > > Does this stop ambari server from requesting all queue metrics from the > > backend? > > What I observed (without this patch) is that besides the regex replace not > > working, multiple queue metrics were requested even though only > > /AppsCompleted was part of the API call.
It's because incorrect worrking of regex relace, metrics/yarn/Queue/$1.replaceAll(\"([.])\",\"/\")/AvailableMB was replaced with metrics/yarn/Queue/$1 After this patch, for the API request below http://host:11081/api/v1/clusters/c1/services/YARN/components/RESOURCEMANAGER?fields=metrics/yarn/Queue/root/default/AppsRunning[1431092463,1431096063,15] AMSPropertyProvider sends http://host:6188/ws/v1/timeline/metrics?metricNames=yarn.QueueMetrics.Queue%3Droot.default.AppsRunning&appId=RESOURCEMANAGER&startTime=1431092463&endTime=1431096063 - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33986/#review83032 ----------------------------------------------------------- On Май 8, 2015, 3:47 п.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33986/ > ----------------------------------------------------------- > > (Updated Май 8, 2015, 3:47 п.п.) > > > Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sid > Wagle. > > > Bugs: AMBARI-11030 > https://issues.apache.org/jira/browse/AMBARI-11030 > > > Repository: ambari > > > Description > ------- > > Queue-specific metrics cannot be retrieved as time-series data via Ambari API. > /api/v1/clusters/c1/services/YARN/components/RESOURCEMANAGER?fields=metrics/yarn/Queue/root/default/AppsRunning > returns the point-in-time metric properly. > However, when you query for it as time-series, in the following format the > API returns nothing: > /api/v1/clusters/c1/services/YARN/components/RESOURCEMANAGER?fields=metrics/yarn/Queue/root/default/AppsRunning[start,end,interval] > The time-series query works if you replace /root/default with /root. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java > a95342a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BaseProviderTest.java > 380142e > > Diff: https://reviews.apache.org/r/33986/diff/ > > > Testing > ------- > > Manual tests passed. > Unit tests execution is in progress > > > Thanks, > > Dmytro Sen > >
