----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33923/#review83517 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On May 12, 2015, 11:14 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33923/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 11:14 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, > and Tom Beerbower. > > > Bugs: AMBARI-10987 > https://issues.apache.org/jira/browse/AMBARI-10987 > > > Repository: ambari > > > Description > ------- > > If I add ¶ms/padding=nulls to the metrics API request > > /api/v1/clusters/c1/hosts/c6401.ambari.apache.org/host_components/NAMENODE?fields=metrics/cpu/cpu_system[1430833471,1430837071,15],metrics/cpu/cpu_user[1430833471,1430837071,15],metrics/cpu/cpu_nice[1430833471,1430837071,15],metrics/cpu/cpu_idle[1430833471,1430837071,15],metrics/cpu/cpu_wio[1430833471,1430837071,15],metrics/memory/mem_total[1430833471,1430837071,15],metrics/memory/mem_free[1430833471,1430837071,15],metrics/memory/mem_cached[1430833471,1430837071,15]¶ms/padding=nulls > > fails: > > { > "status" : 500, > "message" : "org.apache.ambari.server.controller.spi.SystemException: Error > loading deferred resources" > } > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > e27d9a9 > > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/MetricsPaddingRenderer.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java > e63f7eb > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethodFactory.java > a53e26d > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java > 8360f5e > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java > 24f1851 > > ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MetricsPaddingRendererTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33923/diff/ > > > Testing > ------- > > Manually verified. > Related unit tests: ClusterControllerImplTest, All Renderer tests pass. > > > File Attachments > ---------------- > > Fix for NPE. > > https://reviews.apache.org/media/uploaded/files/2015/05/12/b6c883ff-daa8-4769-ad56-674b4ee1ff5f__AMBARI-10987-1.patch > > > Thanks, > > Sid Wagle > >
