-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34474/#review84704
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/script/script.py
<https://reviews.apache.org/r/34474/#comment136047>

    What is the difference from the original and this?
    Original: call set_version() after "install" command was executed.
    
    New: call set_version() at the end of install_packages().


- Alejandro Fernandez


On May 21, 2015, 3:04 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34474/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 3:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-11269
>     https://issues.apache.org/jira/browse/AMBARI-11269
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The problem was in the sequence
> 
> - install() command is executed. It installs packages and tries to create 
> /usr/hdp/current/hbase-client/conf , but /usr/hdp/current/hbase-client is 
> (yet) a broken symlink
> - script.py#set_version() should be launched after install, but is not due to 
> previous exception
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestScript.py 5f21c7a 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> f9eda81 
> 
> Diff: https://reviews.apache.org/r/34474/diff/
> 
> 
> Testing
> -------
> 
> Checked on live cluster, symlinks were created for every component installed
> 
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.906s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.991s]
> [INFO] Ambari Server ..................................... SUCCESS [38.608s]
> [INFO] Ambari Agent ...................................... SUCCESS [22.107s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 1:05.509s
> [INFO] Finished at: Wed May 20 16:31:36 EEST 2015
> [INFO] Final Memory: 53M/432M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to