> On May 28, 2015, 6:53 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py, > > line 51 > > <https://reviews.apache.org/r/34750/diff/1/?file=973307#file973307line51> > > > > Why do we need to check is yarn-site is present. Seems like it's always > > present with Oozie installed.If it's really needed for Oozie service check, > > we are skipping here a ponential early failure, with good informative > > message that 'for some reason yarn-site is not present please check your > > configs' comparing to failing of oozie SC for unkwnown to user reason > > Jonathan Hurley wrote: > Agreed; seems like it would always be in the configurations since we send > all configs down regardless of the type of command or target > service/component.
yarn-site *should* always be there based on the config dependencies, but I'll add an else clause to print a clear error if not present. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34750/#review85523 ----------------------------------------------------------- On May 28, 2015, 2:58 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34750/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 2:58 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-11476 > https://issues.apache.org/jira/browse/AMBARI-11476 > > > Repository: ambari > > > Description > ------- > > This occurs because when Core Masters are upgraded and the round of Service > Checks are ran, the Oozie Service Check does not contain yarn-site.xml in its > config folder. > When Oozie Server is then upgraded, it fails because the tarball of the old > conf folder actually zips the conf folder itself, so when it is unpacked, it > creates /usr/hdp/2.3.0.0-2130/oozie/conf/conf/ > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > acb1e9f > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py > 47361c4 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py > 11f4431 > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py > 219c874 > > Diff: https://reviews.apache.org/r/34750/diff/ > > > Testing > ------- > > Performed an RU from Dal to Dal+ with Oozie, and all of the service checks > and Oozie Server restart passed. > > ---------------------------------------------------------------------- > Total run:743 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
