> On June 1, 2015, 3:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py, > > line 68 > > <https://reviews.apache.org/r/34901/diff/1/?file=975846#file975846line68> > > > > Maybe a note explaining why there are inclusions? Might help future > > debugging when someone removes this :)
Clarification; why there are two different inclusions (one for CentOS and one for RHEL) - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34901/#review86053 ----------------------------------------------------------- On June 1, 2015, 3:35 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34901/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 3:35 p.m.) > > > Review request for Ambari, Jonathan Hurley and Mahadev Konar. > > > Bugs: AMBARI-11592 > https://issues.apache.org/jira/browse/AMBARI-11592 > > > Repository: ambari > > > Description > ------- > > Added 'rhui*' for RHEL 6 to the list of core repos to use when installing > packages. > > This is because the current set used ('base', 'HDP-x.x.x.x', > 'HDP-UTILS-y.y.y.y') doesn't cover a dependency on 'fuse-libs' that is now > required by the stack. > > > Diffs > ----- > > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 9979fde > ambari-server/src/test/python/custom_actions/TestInstallPackages.py 9735bc7 > > Diff: https://reviews.apache.org/r/34901/diff/ > > > Testing > ------- > > Verified manually that using 'rhui*' will not break on centos and 'base' will > not break rhel. > > ---------------------------------------------------------------------- > Ran 235 tests in 6.829s > > OK > ---------------------------------------------------------------------- > Total run:746 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Nate Cole > >
