----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35007/#review86420 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On June 3, 2015, 3:54 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35007/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 3:54 p.m.) > > > Review request for Ambari, Jonathan Hurley and Tom Beerbower. > > > Bugs: AMBARI-11596 > https://issues.apache.org/jira/browse/AMBARI-11596 > > > Repository: ambari > > > Description > ------- > > During the middle of a Rolling Upgrade, the operations get aborted. The UI > shows several as skipped, and the remainder as completed (including Finalize) > even though they didn't actually run. > > Today, the way to get out of this state is to perform the RU manually (call > hdp-select, restart services, call API for clients, run Finalize command, > etc), which is extremely tedious, error-prone, and time-consuming. > > Provide an API that will move ABORTED requests to PENDING. > > (Also squeezed in an unrelated change that that was incorrectly showing > conflicting property values when <vader>there is no conflict</vader>) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java > e047f6d > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 8444862 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java > 9cd569b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 2a0252e > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java > ab19dc9 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 98ecda1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > e533736 > > Diff: https://reviews.apache.org/r/35007/diff/ > > > Testing > ------- > > Manual testing on a deployed cluster with calling the API directly. There is > a separate ticket for UI work to provide a retry button. > > Automated test results pending. > > Tests run: 3030, Failures: 0, Errors: 0, Skipped: 21 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 32:14.510s > [INFO] Finished at: Wed Jun 03 11:44:07 EDT 2015 > [INFO] Final Memory: 32M/1058M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
