-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35009/
-----------------------------------------------------------
Review request for Ambari, John Speidel, Mahadev Konar, and Robert Levas.
Bugs: AMBARI-11659
https://issues.apache.org/jira/browse/AMBARI-11659
Repository: ambari
Description
-------
This patch addresses AMBARI-11659.
When an invalid configuration type was encountered in a Blueprint, the
Blueprint filters that run prior to cluster update would eventually throw an
exception from the stack code. This would cause the cluster to remain in
"INITIAL" mode, and none of the configuration types would be resolved properly
with hostname information, or any other updated property values required for a
cluster deployment with Blueprints.
This patch solves this problem by:
1. Surrounds the call to each filter in a try/catch, which catches Throwable.
In the event that a Throwable is caught, it is logged as potential
configuration error, and processing can continue.
2. Adds a unit test to verify this change.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
9deea1f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
64da8ac
Diff: https://reviews.apache.org/r/35009/diff/
Testing
-------
1. Ran the ambari-server unit tests for Blueprints (all passing). I plan on
running the full ambari-server unit test suite prior to merging.
2. Deployed a single-node cluster using a Blueprint that contained an invalid
configuration type name. Verified that this error is now logged to
ambari-server.log, and also verified that the cluster deployment fully
succeeds, including fully-resolved configuration.
3. Deployed a single-node cluster using a Blueprint without the invalid
configuration type, to make sure that basic Blueprint deployments still succeed
with this change applied.
Thanks,
Robert Nettleton
