> On June 6, 2015, 1:03 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java, > > line 520 > > <https://reviews.apache.org/r/35167/diff/1/?file=980327#file980327line520> > > > > The cluster global lock is not necessary here since no cluster data is > > being read.
Even if CG state is persisted, updates would result in getting a Cluster write lock in order to add configurations that do not exist. This issue arises when parallel calls are made to update Config Groups. One holds the lock on Cluster and the other on CG. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35167/#review86886 ----------------------------------------------------------- On June 6, 2015, 3:38 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35167/ > ----------------------------------------------------------- > > (Updated June 6, 2015, 3:38 a.m.) > > > Review request for Ambari, Jonathan Hurley, Mahadev Konar, Myroslav > Papirkovskyy, and Yusaku Sako. > > > Bugs: AMBARI-11744 > https://issues.apache.org/jira/browse/AMBARI-11744 > > > Repository: ambari > > > Description > ------- > > This was observed while adding Ganglia to an existing cluster via Add > Services Wizard. > It hung after clicking Deploy at task 2 / 6. > Browser tools showed that it was doing a PUT and this call timed out after 3 > mins. > All subsequent API calls hung. Ambari Server was not responsive at all to any > API calls after that. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java > 3fcb84b > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java > 9ec0370 > > Diff: https://reviews.apache.org/r/35167/diff/ > > > Testing > ------- > > Verified manually. > > > Thanks, > > Sid Wagle > >
