----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35530/#review88121 -----------------------------------------------------------
Ship it! Ship It! - Mahadev Konar On June 16, 2015, 7:35 p.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35530/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 7:35 p.m.) > > > Review request for Ambari, John Speidel, Mahadev Konar, Robert Levas, and > Sumit Mohanty. > > > Bugs: AMBARI-11959 > https://issues.apache.org/jira/browse/AMBARI-11959 > > > Repository: ambari > > > Description > ------- > > This patch resolves AMBARI-11959. > > Recent changes in the StackAdvisor code have caused the following Tez > property to be added to a cluster's configuration: > "tez.tez-ui.history-url.base" in "tez-site" > > This property is used to connect the Yarn ResourceManager UI to the Tez UI > located in the Tez View. The UI's stack advisor will set this property > automatically. > > This property now appears in Blueprint exports of running clusters, and the > property value includes hostname information. This makes the exported > Blueprint less portable, since it will require some manual changes to this > property on a different set of machines. > > This property cannot be handled by the current Blueprint config processor, > since the URL required by this property involves information about deployed > Tez View, which is not readily accessible to the Blueprints processor. > > The Blueprint configuration processor should filter out this property during > a Blueprint export. > > This patch implements the following: > > 1. Creates a new filter that can be parameterized with a configuration type > and configuration name. This filter will test to determine if the passed-in > property matches these two attributes. > 2. Registers this new filter with the list of Blueprint export filters. > 3. Adds a unit test to verify this change. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 9d49714 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > a0c29e8 > > Diff: https://reviews.apache.org/r/35530/diff/ > > > Testing > ------- > > 1. Ran the ambari-server unit test suite, all passing. I will also run this > suite against both branches prior to merging. > 2. After deploying an HDFS/Yarn/Tez cluster with my patch applied, I verified > that an exported Blueprint no longer contains this property. > 3. I also verified that the exported Blueprint could be used to successfully > re-create this cluster in a new VM instance. > > > Thanks, > > Robert Nettleton > >
