> On June 18, 2015, 5:07 p.m., Andrew Onischuk wrote: > > maybe it would more readable to move it inside webhcat() func? > > Florian Barca wrote: > Possibly, but Atlas is a separate component, so I thought it makes more > sense to keep the code separate and not mix it up.
We do that actually for hive_client and hive_server, meaning put the function into hive() function so maybe that would be good thing to unify that. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35594/#review88400 ----------------------------------------------------------- On June 18, 2015, 6:23 a.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35594/ > ----------------------------------------------------------- > > (Updated June 18, 2015, 6:23 a.m.) > > > Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush > Luniya. > > > Bugs: AMBARI-11989 > https://issues.apache.org/jira/browse/AMBARI-11989 > > > Repository: ambari > > > Description > ------- > > Moved the Atlas driver code in the Linux-specific implementation. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py > 1b5b76875423c9926d58ce5b068ea57b9d7ce480 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py > 0473d1753a6f9f7b542a61b14f495ba21bb02246 > > Diff: https://reviews.apache.org/r/35594/diff/ > > > Testing > ------- > > mvn clean test -> local VM deployment -> ok > > > Thanks, > > Florian Barca > >
