----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36047/#review89891 -----------------------------------------------------------
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveCall.java (line 51) <https://reviews.apache.org/r/36047/#comment142762> This seems unnecessary since it will be called later if needed. If making other changes, you might want to remove this, else it will be fine. - Robert Levas On June 30, 2015, 9:31 a.m., Erik Bergenholtz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36047/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 9:31 a.m.) > > > Review request for Ambari, Robert Levas and Tom Beerbower. > > > Bugs: AMBARI-12213 > https://issues.apache.org/jira/browse/AMBARI-12213 > > > Repository: ambari > > > Description > ------- > > This patch re-established connection if it is stale > > > Diffs > ----- > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveCall.java > c8b43e2 > > Diff: https://reviews.apache.org/r/36047/diff/ > > > Testing > ------- > > Local unit tests. > -------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.437 sec > Running org.apache.ambari.view.hive.PropertyValidatorTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.117 sec > Running org.apache.ambari.view.hive.resources.files.FileServiceTest > Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.843 sec > Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.225 sec > Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec > Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.012 sec > Running org.apache.ambari.view.hive.resources.jobs.LogParserTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.088 sec > Running > org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.692 sec > Running > org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.153 sec > Running > org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.195 sec > Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.712 sec > > Results : > > Tests run: 48, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Erik Bergenholtz > >
