-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36052/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk, Florian Barca, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-12218
    https://issues.apache.org/jira/browse/AMBARI-12218


Repository: ambari


Description
-------

The host check for JDK does not fail when needed if the JDK is changed to 
manual when running `ambari-server setup` the 2nd time. 

If the JDK is to be manually installed and one or more hosts do not have one 
installed (or it cannot be found during the host check), the JDK host check 
should fail.  However if `ambari-server setup` is run multiple times where the 
first time an automated JDK installation is chosen then the manual option is 
chosen, the `jdk.name` property remains set, _confusing_ the host check process 
and thus not failing the check.

# Steps to reproduce
1. Install ambari-server
2.  install custom JDK on ambari host, only - do not install the JDK anywhere 
else
3.  Execute `ambari-server setup -s`
4.  Execute `ambari-server setup`
5.  Choose to change the Oracle JDK
6.  Select option #3 (Custom JDK)
7.  Enter a valid path to a JDK
8.  Complete setup
9.  Start Ambari 
10.  Start to create a cluster
11.  Enter hosts
12.  After the host check, look at the warnings and see that *no error* exists 
for hosts where a JDK was not found

# Solution
Ensure that `jdk.name` and `jce.name` are not set in the ambari.properties file 
when the custom JDK option is specified.


Diffs
-----

  ambari-server/src/main/python/ambari_server/serverSetup.py ede1cf3 

Diff: https://reviews.apache.org/r/36052/diff/


Testing
-------


Thanks,

Robert Levas

Reply via email to