----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36330/#review90987 -----------------------------------------------------------
Ship it! Ship It! - Sumit Mohanty On July 8, 2015, 8:51 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36330/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 8:51 p.m.) > > > Review request for Ambari, Sumit Mohanty, Srimanth Gunturi, and Sid Wagle. > > > Bugs: AMBARI-10743 > https://issues.apache.org/jira/browse/AMBARI-10743 > > > Repository: ambari > > > Description > ------- > > I have an additional patch for this in which for HDP 2.1, it should not have > the currentWeek and lastWeek functions defined. This is because the original > patch had it in common-services, which is inherited by HDP 2.1, 2.2, and 2.3. > Only 2.2 and higher can support these functions. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/oozie-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/configuration/oozie-site.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/36330/diff/ > > > Testing > ------- > > Verified that the lastWeek and currentWeek functions still exist at these > endpoints, > /api/v1/stacks/HDP/versions/2.2/services/FALCON/configurations/oozie.service.ELService.ext.functions.coord-job-submit-data > /api/v1/stacks/HDP/versions/2.3/services/FALCON/configurations/oozie.service.ELService.ext.functions.coord-job-submit-data > > But not in, > /api/v1/stacks/HDP/versions/2.1/services/FALCON/configurations/oozie.service.ELService.ext.functions.coord-job-submit-data > as expected. > > Unit tests passed, > > ---------------------------------------------------------------------- > Total run:768 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
