> On Июль 15, 2015, 3:22 п.п., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java, > > lines 449-462 > > <https://reviews.apache.org/r/36508/diff/2/?file=1012756#file1012756line449> > > > > I'm not sure what this Jira has to with upgrades. The description says > > that the config attributes are not preserved after enabling security. > > > > However, if you have found a problem with upgrades as well where we are > > not preserving attributes on an upgrade, this is the wrong place to do this > > work. > > > > It should probably be done as part of the UpgradeResourceProvider where > > it creates the new configurations when going from HDP 2.2 to 2.3
Fixing only enabling security in my new patch - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36508/#review91744 ----------------------------------------------------------- On Июль 15, 2015, 2:36 п.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36508/ > ----------------------------------------------------------- > > (Updated Июль 15, 2015, 2:36 п.п.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-12419 > https://issues.apache.org/jira/browse/AMBARI-12419 > > > Repository: ambari > > > Description > ------- > > The issue is noticed in an RU cluster where rolling upgrade has to be > performed with ambari2.1.0. After installing dal bits we are setting final > flag for a property 'tez.am.resource.memory.mb' to final which you can see in > V3 config of the cluster. Then enabling security and HA is performed. After > these operations we see that the final flag was turned off. Upon checking the > versions, V4 doesn't have this final flag and changes between V3 and V4 is > that, security is enabled at V4. (HiveServer2 Authentication is set to > kerberos in V4 not in V3). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > c717582 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 8b4b1e2 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java > c54039f > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > 2c9bf30 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java > 93f7f8c > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java > 484c18d > > Diff: https://reviews.apache.org/r/36508/diff/ > > > Testing > ------- > > unit tests are in progress > > > Thanks, > > Dmytro Sen > >
