-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36564/#review91998
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 (line 52)
<https://reviews.apache.org/r/36564/#comment145828>

    Will expand these imports.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 (line 774)
<https://reviews.apache.org/r/36564/#comment145830>

    This addresses an issue so that delete on
    /api/v1/hosts/name
    and
    /api/v1/clusters/name/hosts/name
    
    both check that the host doesn't have any active components.



ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
 (line 22)
<https://reviews.apache.org/r/36564/#comment145831>

    Will expand these imports



ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 (line 806)
<https://reviews.apache.org/r/36564/#comment145834>

    When a DataNode is decommissioned, it inserts a record into the 
requestoperationlevel table, so it's important to try to delete from this table 
as well.



ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 (line 1162)
<https://reviews.apache.org/r/36564/#comment145832>

    I don't know yet if I can print the host name here.


- Alejandro Fernandez


On July 17, 2015, 12:38 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36564/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 12:38 a.m.)
> 
> 
> Review request for Ambari, John Speidel, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-12429
>     https://issues.apache.org/jira/browse/AMBARI-12429
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Created a cluster with multiple hosts, then stopped all of the services on 1 
> host (preferably one with only clients so it has nothing to stop). Then 
> deleted the host using the API.
> E.g., curl -u admin:admin -H "X-Requested-By: ambari" -X DELETE 
> http://c6401.ambari.apache.org:8080/api/v1/hosts/c6404.ambari.apache.org
> This led to Null Pointer Exceptions in ambari-server
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java
>  faebb20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  de9ae52 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  4c14426 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java
>  c7c0160 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  fa49d7f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestOperationLevelDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
>  2c11e55 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  665dd56 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  9f25ad7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java
>  bd4ad90 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  ed8336e 
> 
> Diff: https://reviews.apache.org/r/36564/diff/
> 
> 
> Testing
> -------
> 
> Still running system tests, and waiting for unit test results.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Reply via email to