----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36589/#review92143 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On July 17, 2015, 11:47 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36589/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 11:47 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and > Sumit Mohanty. > > > Bugs: AMBARI-12454 > https://issues.apache.org/jira/browse/AMBARI-12454 > > > Repository: ambari > > > Description > ------- > > Metrics monitor start script should not fail if daemon already running with > correct PID > > > Checking for previously running Metric Monitor... > tput: No value for $TERM and no -T specified > ERROR: ambari-metrics-monitor already running > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-host-monitoring/conf/unix/ambari-metrics-monitor > 86c2ac7 > > Diff: https://reviews.apache.org/r/36589/diff/ > > > Testing > ------- > > Manually verified: > > [root@ams-test-1 ~]# su - ams -c '/usr/sbin/ambari-metrics-monitor --config > /etc/ambari-metrics-monitor/conf start' > psutil build directory is not empty, continuing... > Verifying Python version compatibility... > Using python /usr/bin/python2.6 > Checking for previously running Metric Monitor... > WARN: ambari-metrics-monitor already running with PID: 6090 > Exiting. > > [root@ams-test-1 ~]# echo $? > 0 > > > Thanks, > > Sid Wagle > >
