> On July 21, 2015, 9:57 p.m., Yusaku Sako wrote: > > Ship It!
Actually, can you add unit tests for this? We should cover the cases where the GET persist response is 1) uncompressed and 2) compressed. - Yusaku ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36500/#review92485 ----------------------------------------------------------- On July 21, 2015, 9:54 p.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36500/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 9:54 p.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-12417 > https://issues.apache.org/jira/browse/AMBARI-12417 > > > Repository: ambari > > > Description > ------- > > Apply base64 compression for post payload when persisting cluster status. > > > Diffs > ----- > > ambari-web/app/models/cluster_states.js 9f3ccac > ambari-web/app/utils/lz-string.js PRE-CREATION > > Diff: https://reviews.apache.org/r/36500/diff/ > > > Testing > ------- > > Manually tested on live cluster. > All unit tests passed. > 6475 tests complete (10 seconds) > 90 tests pending > > > Thanks, > > Richard Zang > >
