----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36888/#review93285 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On July 28, 2015, 12:45 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36888/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 12:45 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-12564 > https://issues.apache.org/jira/browse/AMBARI-12564 > > > Repository: ambari > > > Description > ------- > > Today if Ambari Agent python code throws the exception and the stack trace get > rerouted to /var/log/ambari_agent/ambari_agent.out . This is not logged by our > agent and therefore it makes it hard to RCA Ambari Agent failures, let alone > know that Ambari Agent failed. > I am hoping it is possible to wrap the entry code to Ambari Agent in a > try/catch and log the error message and stack trace to the log appenders and > only then have ambari agent throw. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/main.py 0971cbb > > Diff: https://reviews.apache.org/r/36888/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
