----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37043/#review93918 -----------------------------------------------------------
Ship it! Ship It! - Dmytro Sen On Авг. 3, 2015, 5:16 п.п., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37043/ > ----------------------------------------------------------- > > (Updated Авг. 3, 2015, 5:16 п.п.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-12624 > https://issues.apache.org/jira/browse/AMBARI-12624 > > > Repository: ambari > > > Description > ------- > > UpgradeHelper should work with: > different default ambari port, AND > if ambari is setup for https. Cannot assume 8443 for https > Add command line options for PORT and PROTOCOL. > Change api_port and api_protocol from default > in upgradeHelper.py for Ambari. This needs to be well documented. > [root@f11d > upgrade_hdp_226]# diff upgradeHelper.py upgradeHelper.py.old > 185,186c185,186 > < API_PROTOCOL > = "https" > < API_PORT > = "8443" > --- > > API_PROTOCOL > = "http" > > API_PORT > = “8080" > > > Diffs > ----- > > ambari-server/src/main/python/upgradeHelper.py c38ce5f > ambari-server/src/test/python/TestUpgradeHelper.py 5aca13d > > Diff: https://reviews.apache.org/r/37043/diff/ > > > Testing > ------- > > Ran 241 tests in 6.076s > > OK > ---------------------------------------------------------------------- > Total run:784 > Total errors:0 > Total failures:0 > OK > > Process finished with exit code 0 > > > Thanks, > > Dmitro Lisnichenko > >