----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37003/ -----------------------------------------------------------
(Updated Aug. 4, 2015, 6:08 a.m.) Review request for Ambari and Yusaku Sako. Bugs: AMBARI-12615 https://issues.apache.org/jira/browse/AMBARI-12615 Repository: ambari Description ------- Refer to the description in AMBARI-12615 Diffs ----- ambari-web/app/views/main/views/details.js e90cb20 contrib/views/hive/pom.xml 39f6848 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java a0d44f5 contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java 526f13f contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java 18152ad contrib/views/hive/src/main/resources/ui/hive-web/.jshintrc c1fe863 contrib/views/hive/src/main/resources/ui/hive-web/app/components/visualization-tabs-widget.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/query-tabs.js 4f5176c contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visualization-ui.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js af5e3a7 contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/visualization-tabs-widget.hbs PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/templates/visualization-ui.hbs PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js e4e445a contrib/views/hive/src/main/resources/ui/hive-web/app/views/visualization-ui.js PRE-CREATION contrib/views/hive/src/main/resources/ui/hive-web/bower.json 37ea901 Diff: https://reviews.apache.org/r/37003/diff/ Testing (updated) ------- Tested manually with different datasets of different size. Tested switching to visualization tab with multiple SQL tabs having different queries. Tested switching between the two visualization tabs multiple times. Tested with upto 30000 rows in the resultset with all possible combinations of scale and chart types. Tested with Google Chrome, Safari, Firefox and Internet Explorer 10. Tested end to end with Ambari Web and Hive View. Existing Ambari Web unit tests pass. 6482 tests complete (22 seconds) 94 tests pending [INFO] [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web --- [INFO] 51 implicit excludes (use -debug for more details). [INFO] Exclude: .idea/** [INFO] Exclude: package.json [INFO] Exclude: public/** [INFO] Exclude: public-static/** [INFO] Exclude: app/assets/** [INFO] Exclude: vendor/** [INFO] Exclude: node_modules/** [INFO] Exclude: node/** [INFO] Exclude: npm-debug.log [INFO] 1169 resources included (use -debug for more details) Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. Compiler warnings: WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.' Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1169 licence. [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 49.809s [INFO] Finished at: Fri Jul 31 18:39:11 PDT 2015 [INFO] Final Memory: 12M/439M [INFO] ------------------------------------------------------------------------ Automated QA test pass. -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12748591/AMBARI-12615.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in contrib/views/hive. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3520//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3520//console Thanks, Vivek Ratnavel Subramanian