> On Aug. 10, 2015, 9:28 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/rack_awareness.py, > > line 28 > > <https://reviews.apache.org/r/36519/diff/2/?file=1036614#file1036614line28> > > > > Shouldn't use "dir" as a variable name since it's already a function > > name. > > Alejandro Fernandez wrote: > Thanks, is this meant for trunk and 2.1.1? > > Alejandro Fernandez wrote: > I tried on trunk, and this will have to be rebased. > > Di Li wrote: > Hello Alejandro, > > Sorry for the inconvenience. Yes, this one is meant for trunk and 2.1.1. > I was on leave for 2.5 weeks so my code base for the diff is a bit old.
Di, can you rebase so I can try again on trunk? Is this a blocker for branch 2.1.1 (which was already cut) or can it go into release 2.1.2? - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36519/#review94800 ----------------------------------------------------------- On Aug. 10, 2015, 9:52 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36519/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 9:52 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-12349 > https://issues.apache.org/jira/browse/AMBARI-12349 > > > Repository: ambari > > > Description > ------- > > When configure hadoop from install wizard, set "File that stores mount point" > or "net.topology.script.file.name" to a non default location, e.g > > /etc/hadoop1/conf/dfs_data_dir_mount.hist > /etc/hadoop1/conf/topology_script.py > > install failed because datanode could not be start, with error message > > Applying File['/etc/hadoop1/conf/topology_mappings.data'] failed, parent > directory /etc/hadoop1/conf doesn't exist > > > This is because rack_awareness.py only handles the creation of the file but > not the parent directory. Default value doesn't have this problem because the > directory /etc/hadoop/conf was created in yum install. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/rack_awareness.py > 6b0bff6 > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py > df39d2f > > Diff: https://reviews.apache.org/r/36519/diff/ > > > Testing > ------- > > unit test: test_hook_refresh_topology_custom_directories > (test_before_start.TestHookBeforeStart) ... ok > > > Thanks, > > Di Li > >
