----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37213/#review94988 -----------------------------------------------------------
Ship it! Ship It! - Srimanth Gunturi On Aug. 7, 2015, 11:30 a.m., DIPAYAN BHOWMICK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37213/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2015, 11:30 a.m.) > > > Review request for Ambari, Mahadev Konar, Sid Wagle, and Yusaku Sako. > > > Bugs: https://issues.apache.org/jira/browse/AMBARI-12667 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-12667 > > > Repository: ambari > > > Description > ------- > > 1. Saved queries cannot be sorted by title: The quries controller is a > ArrayController and there is a property defined as model which is being used > to render the table rows in queries.hbs template file. As when the user > clicks the sort button on any column title, the ```sortProperties``` and > ```sortAscending``` were updated properly and the ```arrangedContent``` > propery is implicitly changed in the controller. But as the #each loop is > done over the ```model``` property, the table rows were not getting sorted in > the template. Hence, to make it work the #each loop were changed to > ```this```, which essentially proxies over the ```arrangedContent``` property. > > 2. Udfs cannot be sorted: The chnages done is same as described in problem 1. > The Udfs controller is changed to an Array Controller and the #each looping > is done over this to get the result from ```arrangedContent``` > > > Diffs > ----- > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/udfs.js > 6804260 > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/queries.hbs > c71a03b > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/udfs.hbs > 4cd1a97 > > Diff: https://reviews.apache.org/r/37213/diff/ > > > Testing > ------- > > Manually tested. Executed the ui test scripts.(```ember test```) > > > Thanks, > > DIPAYAN BHOWMICK > >
