----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37606/#review95992 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On Aug. 19, 2015, 8:49 a.m., DIPAYAN BHOWMICK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37606/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 8:49 a.m.) > > > Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-12814 > https://issues.apache.org/jira/browse/AMBARI-12814 > > > Repository: ambari > > > Description > ------- > > 1. Display of the Updated timestamp below the name of the file/folder in the > name column is removed. > 2. A new column 'Last Modified' added after the 'size' column. The last > updated time is displayed on that field in for each row. > 3. 'Date' is renamed to 'Last Modified' in the sorting dropdown in the table > header. > > Changes done: > 1. Added a observable property 'isSortPropertyEqualsDate' in > 'controller/files.js' which checks if the sort property is 'date'. This is > used in the template to show 'Last Modified' in place of 'Date' in the sort > dropdown. > 2. Templates changed accordingly. > 3. 'application.less' changed to accomodate a new column in the table. > > > Diffs > ----- > > contrib/views/files/src/main/resources/ui/app/controllers/files.js 74e70c0 > contrib/views/files/src/main/resources/ui/app/styles/application.less > 6f858dd > contrib/views/files/src/main/resources/ui/app/templates/files.hbs c784db6 > contrib/views/files/src/main/resources/ui/app/templates/util/fileRow.hbs > cffd0f4 > > Diff: https://reviews.apache.org/r/37606/diff/ > > > Testing > ------- > > Manually Tested in local VM. > > > Thanks, > > DIPAYAN BHOWMICK > >
