> On Aug. 24, 2015, 9:02 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, > > line 73 > > <https://reviews.apache.org/r/37725/diff/1/?file=1048573#file1048573line73> > > > > What happens if this value is not provided? > > Below in the code, there's a call to Directory, that doesn't check if > > the property is not None > > > > All of these should have default values, and the code should be more > > robust in case properties are missing.
Updated in latest diff - Gautam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37725/#review96207 ----------------------------------------------------------- On Aug. 25, 2015, 9:17 a.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37725/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 9:17 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, > Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako. > > > Bugs: AMBARI-12864 > https://issues.apache.org/jira/browse/AMBARI-12864 > > > Repository: ambari > > > Description > ------- > > Allow user to specify a custom service user to be used for Ranger and Ranger > KMS > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 0d2a6d3 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > c9aa97f > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 5f6b8fe > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 75371b8 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 6f039b2 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > a3aa5bb > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > d9bb941 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 9d895f4 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > f3914f3 > > Diff: https://reviews.apache.org/r/37725/diff/ > > > Testing > ------- > > Tested on a local centos6 cluster with a custom user. > > ---------------------------------------------------------------------- > Ran 231 tests in 6.497s > > OK > ---------------------------------------------------------------------- > Total run:784 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Gautam Borad > >
