----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37755/#review96319 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Aug. 25, 2015, 9:56 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37755/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 9:56 a.m.) > > > Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko. > > > Bugs: AMBARI-12869 > https://issues.apache.org/jira/browse/AMBARI-12869 > > > Repository: ambari > > > Description > ------- > > The code should be changed from store_false to store_true in order for the > --https cli-opt to work: > FROM: > parser.add_option('--https', default=False, action="store_false", > dest="https", help="Use https protocol for connection to the server") > TO: > parser.add_option('--https', default=False, action="store_true", > dest="https", help="Use https protocol for connection to the server") > > > Diffs > ----- > > ambari-server/src/main/python/upgradeHelper.py 7da5e5f > > Diff: https://reviews.apache.org/r/37755/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
