-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38048/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-12971
https://issues.apache.org/jira/browse/AMBARI-12971
Repository: ambari
Description
-------
- Added code for including visualization feature for HIVE view.
- Implemented code for enabling the visualization tab only after select query
gives result successfully.
Diffs
-----
ambari-web/app/views/main/views/details.js e90cb20
contrib/views/hive/pom.xml dc0d5f6
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/browser/HiveBrowserService.java
a0d44f5
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
526f13f
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/ResultsPaginationController.java
18152ad
contrib/views/hive/src/main/resources/ui/hive-web/.jshintrc c1fe863
contrib/views/hive/src/main/resources/ui/hive-web/app/components/visualization-tabs-widget.js
PRE-CREATION
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/query-tabs.js
4f5176c
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visualization-ui.js
PRE-CREATION
contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js
1ce3d9d
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/visualization-tabs-widget.hbs
PRE-CREATION
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/query-tabs.hbs
bea77ba
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/visualization-ui.hbs
PRE-CREATION
contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js
e4e445a
contrib/views/hive/src/main/resources/ui/hive-web/app/views/visualization-ui.js
PRE-CREATION
contrib/views/hive/src/main/resources/ui/hive-web/bower.json 37ea901
Diff: https://reviews.apache.org/r/38048/diff/
Testing
-------
Tested manually with different datasets of different size.
Tested switching to visualization tab with multiple SQL tabs having different
queries.
Tested switching between the two visualization tabs multiple times.
Tested with upto 30000 rows in the resultset with all possible combinations of
scale and chart types.
Tested with Google Chrome, Safari, Firefox and Internet Explorer 10.
Tested end to end with Ambari Web and Hive View.
Here is the build log:
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.372 sec
Running org.apache.ambari.view.hive.PropertyValidatorTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 sec
Running org.apache.ambari.view.hive.resources.files.FileServiceTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.515 sec
Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.162 sec
Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.113 sec
Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.664 sec
Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.049 sec
Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.44 sec
Running
org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.094 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.431 sec
Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.453 sec
Results :
Tests run: 48, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ hive ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.gitattributes
[INFO] Exclude: .idea/
[INFO] Exclude: pass.txt
[INFO] Exclude: .DS_Store
[INFO] Exclude: .iml/
[INFO] Exclude: .classpath
[INFO] Exclude: .project
[INFO] Exclude: .settings
[INFO] Exclude: **/target/**
[INFO] Exclude: **/.gitkeep
[INFO] Exclude: **/.bowerrc
[INFO] Exclude: **/.editorconfig
[INFO] Exclude: **/.jshintrc
[INFO] Exclude: **/.tmp/**
[INFO] Exclude: **/tmp/**
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/bin
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/public/**
[INFO] Exclude: **/dist/**
[INFO] Exclude: **/bower_components/**
[INFO] Exclude: **/bower/**
[INFO] Exclude: **/node/**
[INFO] Exclude: **/runner.js
[INFO] Exclude: **/assets/javascripts/**
[INFO] Exclude: **/assets/stylesheets/**
[INFO] Exclude: **/assets/static/javascripts/**
[INFO] Exclude: **/assets/static/stylesheets/**
[INFO] Exclude: storm/src/main/resources/**
[INFO] 313 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
Compiler warnings:
WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property
'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning: org.apache.xerces.parsers.SAXParser: Feature
'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property
'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0
approved: 312 licence.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ hive ---
[INFO] Building jar:
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/latest-branch-2.1/contrib/views/hive/target/hive-1.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ hive ---
[INFO] Reading assembly descriptor:
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/latest-branch-2.1/ambari-project/src/main/assemblies/empty.xml
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ hive ---
[INFO] Installing
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/latest-branch-2.1/contrib/views/hive/target/hive-1.0.0-SNAPSHOT.jar
to
/Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0-SNAPSHOT/hive-1.0.0-SNAPSHOT.jar
[INFO] Installing
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/latest-branch-2.1/contrib/views/hive/pom.xml
to
/Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0-SNAPSHOT/hive-1.0.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40.411s
[INFO] Finished at: Wed Sep 02 15:56:37 IST 2015
[INFO] Final Memory: 62M/1128M
[INFO] ------------------------------------------------------------------------
Thanks,
Pallav Kulshreshtha
