----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37682/#review98029 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (line 624) <https://reviews.apache.org/r/37682/#comment154177> This function is allowed to return null, let's make sure the value isn't null before we pass it to another function. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (line 651) <https://reviews.apache.org/r/37682/#comment154176> FYI, for STW Upgrade, we'll need to apply configs after all services have been stopped, and before calling hdp-select set all. For now, I'm ok with just getting this patch in. ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java (line 231) <https://reviews.apache.org/r/37682/#comment154179> Why was <UpgradePack.OrderService> removed? ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java (line 282) <https://reviews.apache.org/r/37682/#comment154178> Why was <Task> removed? ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java (line 151) <https://reviews.apache.org/r/37682/#comment154182> Let's use isEmpty or isBlank instead. ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java (line 375) <https://reviews.apache.org/r/37682/#comment154183> For the sake of getting this in, let's ignore unit tests for now. - Alejandro Fernandez On Sept. 8, 2015, 3:37 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37682/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2015, 3:37 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-12700 > https://issues.apache.org/jira/browse/AMBARI-12700 > > > Repository: ambari > > > Description > ------- > > The configs need to move out of the Upgrade Packs and into their own file. > This will make it easier to maintain, and clearer since there will not be any > dups. > > Since it is going to be a massive change, it would be great to get early > feedback. Code is not complete (still full of TODOs and does not even build) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 4afa9b0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > dddec73 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > c717582 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java > aa8e17b > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionDirectory.java > 8f81b5a > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java > db947ca > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > 4b88aff > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > 87301e5 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > ecefe6e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/ConfigUpgradePatch.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 8361ea6 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 8361ea6 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java > 9d89b7a > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java > c9c6b8c > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 7c1a1f9 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 7c1a1f9 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > e702e0a > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 2eee2df > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java > fc731d9 > > Diff: https://reviews.apache.org/r/37682/diff/ > > > Testing > ------- > > just published preview of changes > > > Thanks, > > Dmitro Lisnichenko > >
