-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38254/
-----------------------------------------------------------
(Updated Sept. 10, 2015, 12:33 p.m.)
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-13055
https://issues.apache.org/jira/browse/AMBARI-13055
Repository: ambari
Description
-------
Implemented more options for maximum number of rows for visulization.
Diffs
-----
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visualization-ui.js
3376a03
contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 398a8ef
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/visualization-tabs-widget.hbs
f46b709
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/visualization-ui.hbs
79c0f63
contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js
c5d5cf0
Diff: https://reviews.apache.org/r/38254/diff/
Testing (updated)
-------
Tested manually with different datasets of different size.
Tested switching between the two visualization tabs multiple times.
Tested with Google Chrome, Safari, Firefox and Internet Explorer 10.
Tested end to end with Ambari Web and Hive View.
Tested with all the given options 10000, 30000, 50000, 80000, 100000, 130000,
150000, 180000 and 200000 rows in the resultset with all possible combinations
of scale and chart types.
Here is the build log:
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.348 sec
Running org.apache.ambari.view.hive.PropertyValidatorTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 sec
Running org.apache.ambari.view.hive.resources.files.FileServiceTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.361 sec
Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.166 sec
Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.116 sec
Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.672 sec
Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 sec
Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.46 sec
Running
org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.499 sec
Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.464 sec
Results :
Tests run: 48, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ hive ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.gitattributes
[INFO] Exclude: .idea/
[INFO] Exclude: pass.txt
[INFO] Exclude: .DS_Store
[INFO] Exclude: .iml/
[INFO] Exclude: .classpath
[INFO] Exclude: .project
[INFO] Exclude: .settings
[INFO] Exclude: **/target/**
[INFO] Exclude: **/.gitkeep
[INFO] Exclude: **/.bowerrc
[INFO] Exclude: **/.editorconfig
[INFO] Exclude: **/.jshintrc
[INFO] Exclude: **/.tmp/**
[INFO] Exclude: **/tmp/**
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/bin
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/public/**
[INFO] Exclude: **/dist/**
[INFO] Exclude: **/bower_components/**
[INFO] Exclude: **/bower/**
[INFO] Exclude: **/node/**
[INFO] Exclude: **/runner.js
[INFO] Exclude: **/assets/javascripts/**
[INFO] Exclude: **/assets/stylesheets/**
[INFO] Exclude: **/assets/static/javascripts/**
[INFO] Exclude: **/assets/static/stylesheets/**
[INFO] Exclude: storm/src/main/resources/**
[INFO] 313 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
Compiler warnings:
WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property
'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning: org.apache.xerces.parsers.SAXParser: Feature
'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property
'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not
recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0
approved: 312 licence.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ hive ---
[INFO] Building jar:
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/branch-2.1-sept-3/contrib/views/hive/target/hive-1.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ hive ---
[INFO] Reading assembly descriptor:
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/branch-2.1-sept-3/ambari-project/src/main/assemblies/empty.xml
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ hive ---
[INFO] Installing
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/branch-2.1-sept-3/contrib/views/hive/target/hive-1.0.0-SNAPSHOT.jar
to
/Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0-SNAPSHOT/hive-1.0.0-SNAPSHOT.jar
[INFO] Installing
/Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/branch-2.1-sept-3/contrib/views/hive/pom.xml
to
/Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0-SNAPSHOT/hive-1.0.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40.222s
[INFO] Finished at: Thu Sep 10 18:02:38 IST 2015
[INFO] Final Memory: 60M/1047M
[INFO] ------------------------------------------------------------------------
Thanks,
Pallav Kulshreshtha
