-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38388/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 10:11 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
Hurley, and Nate Cole.


Changes
-------

Addressed comments.


Bugs: AMBARI-13052
    https://issues.apache.org/jira/browse/AMBARI-13052


Repository: ambari


Description
-------

For a Stop-and-Start Upgrade from HDP 2.1 -> 2.3, we need to stop all services 
using the scripts for HDP 2.1, and then start them using HDP 2.3.

Today, during an Upgrade, we currently set the desired stack id when we process 
Upgrade Pack and insert the upgrade record. That means that all start/stop 
commands use the scripts from the desired stack.

Instead, we need a Server Side Action to be called right before we run 
"hdp-select set all" that will change the desired stack id to the new version; 
this will permit stopping on the old version, and starting on the new version.

When we downgrade, we commence the orchestration again, and we again call the 
Server Side Action to change the desired stack id, this time to the starting 
version.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 6ac3ed7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 a7f206a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 6133885 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 c73f9d4 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
d86210a 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
442c9ed 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 ec0fabf 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServerActionTask.java
 ea59d65 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpdateStackGrouping.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
 c55e1a8 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
 01022b8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 6708422 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
 b746bc1 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java
 1f27cb3 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_nonrolling.xml
 13c5d1f 

Diff: https://reviews.apache.org/r/38388/diff/


Testing
-------

Verified it worked during a Stop-the-World Upgrade.
Unit tests passed.


Thanks,

Alejandro Fernandez

Reply via email to