----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38220/ -----------------------------------------------------------
(Updated Sept. 16, 2015, 3:40 p.m.) Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole. Changes ------- Published a patch that should be good to go in Summary (updated) ----------------- Stop-and-Start Upgrade: apply configs after all services have been stopped Bugs: AMBARI-13048 https://issues.apache.org/jira/browse/AMBARI-13048 Repository: ambari Description ------- Goal: for STW Upgrade, we'll need to apply configs after all services have been stopped, and before calling hdp-select set all. I think, we have to add separate groups before and after restart of HIVE server to enforce config application order during UPGRADE and DONGRADE. Looks like that is the only config change required for 2.2->2.2+ upgrade. Does such upgrade pack definition look good? Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 8f4870c ambari-server/src/main/java/org/apache/ambari/server/state/stack/ConfigUpgradePack.java 2896255 ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java 6ae0a15 ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 743204c0 ambari-server/src/test/java/org/apache/ambari/server/checks/UpgradeCheckStackVersionTest.java 8d8b08f ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradePackTest.java PRE-CREATION Diff: https://reviews.apache.org/r/38220/diff/ Testing (updated) ------- Failed test mentioned below fails also on latest branch-dev-stop-all-upgrade commits Results : Tests in error: UpgradeResourceProviderHDP22Test.testCreateIntraStackUpgrade:266 ยป System An i... Tests run: 3138, Failures: 0, Errors: 1, Skipped: 27 [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Ambari Views ...................................... SUCCESS [3.193s] [INFO] Ambari Metrics Common ............................. SUCCESS [1.556s] [INFO] Ambari Server ..................................... FAILURE [51:24.274s] [INFO] Ambari Agent ...................................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 51:29.595s [INFO] Finished at: Wed Sep 16 18:32:55 EEST 2015 [INFO] Final Memory: 69M/1708M Thanks, Dmitro Lisnichenko