----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38559/#review99766 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Sept. 21, 2015, 5:19 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38559/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 5:19 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin > Jetly, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-13152 > https://issues.apache.org/jira/browse/AMBARI-13152 > > > Repository: ambari > > > Description > ------- > > Current issue is caused by commit AMBARI-13107 ("After successful install of > Oozie via blueprint, oozie has an invalid configuration") . Mentioned commit > removes few "value" sections from service metainfo. That's why some > properties in stack metainfo may have null values. > > A litle more details about the case I'm fixing: > Both previous stack value and next stack value are null (not defined in > metainfo to avoid parsing by blueprint). But runtime property value after > upgrade is not-null (added by UpgradeCatalog). I'm fixing exactly this case, > other cases (only new or old stack property value is null and other is not) > are a way different because of bug nature. > > UPD we decided to commit the fix to 2.1.2 as well since mentioned patch is > hard to revert (other patches are based on it) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java > 9a2c604 > > Diff: https://reviews.apache.org/r/38559/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [3.262s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.659s] > [INFO] Ambari Server ..................................... SUCCESS > [53:43.587s] > [INFO] Ambari Agent ...................................... SUCCESS [9.281s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 53:58.376s > [INFO] Finished at: Mon Sep 21 18:54:27 EEST 2015 > [INFO] Final Memory: 73M/1692M > > > Thanks, > > Dmitro Lisnichenko > >
