----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38788/#review100760 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On Sept. 26, 2015, 9:03 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38788/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2015, 9:03 p.m.) > > > Review request for Ambari, Dmytro Sen, Jayush Luniya, Mahadev Konar, and > Sumit Mohanty. > > > Bugs: AMBARI-13251 > https://issues.apache.org/jira/browse/AMBARI-13251 > > > Repository: ambari > > > Description > ------- > > During the Clients group of RU, restarting hdfs_client changes changes the > symlink /usr/hdp/current/hadoop-client/ from the old version to the new > version. > > Because the Data Dir Mount History file is stored at > /etc/hadoop/conf/dfs_data_dir_mount.hist and > /etc/hadoop/conf symlinks to /usr/hdp/current/hadoop-client/conf > it means that the file must be copied to the new location. > > Multiple clients (HDFS, HBase, Hive, YARN, MapReduce, Pig, Slider, Tez) > actually end up calling > {code} > hdp_select.select("hadoop-client", params.version) > {code} > that changes the symlink, so the first one to be ran during RU must copy the > file. If DataNode is present, it means that HDFS Client is guaranteed to be > there, and from all of those clients it is the first one in the Upgrade Pack. > > During a Rolling Downgrade, the file should already exist in the previous > version, and the file is only written to when DataNode is restarted, so we > are ok. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > dd0dca4 > > Diff: https://reviews.apache.org/r/38788/diff/ > > > Testing > ------- > > Tested the alert during RU, and the mount history file was copied to the new > location, so no warnings were generated. > > Python unit tests passed, > ---------------------------------------------------------------------- > Total run:805 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >