----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38806/#review101370 -----------------------------------------------------------
ambari-agent/src/main/package/rpm/postremove.sh (line 27) <https://reviews.apache.org/r/38806/#comment158735> My suggestion here is that this type of logic may lead to bugs in the future, once we support a higher version of python, because ambari python wrap has its own logic for picking the python version. Python isn't necessarily guaranteed to be in that location, so ideally we would either A. Iterate over all of the versions of python installed and attempt to delete these ambari folders Or B. Share the same logic that calculates which python version to use, and call it from this script. This is something that requires testing on non-default paths of Python, and also multiple python versions installed. E.g., only 2.6, only 2.7, or both. - Alejandro Fernandez On Oct. 1, 2015, 8:13 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38806/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 8:13 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid > Wagle. > > > Bugs: AMBARI-13242 > https://issues.apache.org/jira/browse/AMBARI-13242 > > > Repository: ambari > > > Description > ------- > > The uninstall script in RPM does not clean up the symbolic links created in > /usr/lib/python2.6/site-packages. The broken links causes following err if > user tries to install Ambari server on a node that has been previously > installed with Ambari agent. Vise Versa. > > File "/usr/sbin/ambari-server.py", line 26, in <module> > from ambari_commons.exceptions import FatalException, NonFatalException > File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in > <module> > File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, > in <module> > File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, > in _init_ > File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, > in initialize_data > > > Diffs > ----- > > ambari-agent/pom.xml 0096162 > ambari-agent/src/main/package/rpm/postremove.sh PRE-CREATION > ambari-server/pom.xml 3377961 > ambari-server/src/main/package/rpm/postremove.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/38806/diff/ > > > Testing > ------- > > Generate Ambari Server and Agent RPMs > Install the Ambari Agent RPM on a machine > Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in > /usr/lib/python2.6/site-packages are removed. > On the very same machine, now install Ambari Server RPM > verify the RPM > install is successful, and can start/stop Ambari server. > Run yum erase to remove the Ambari Server RPM > verify the symbolic links in > /usr/lib/python2.6/site-packages are removed. > > > Thanks, > > Di Li > >
