> On Oct. 5, 2015, 8:05 p.m., Andrew Onischuk wrote: > > ambari-server/conf/unix/install-helper.sh, line 52 > > <https://reviews.apache.org/r/38806/diff/5/?file=1091197#file1091197line52> > > > > There is a typo, rather than that looks good. > > Di Li wrote: > Hello Andrew, > > Thanks for the review. please find the latest patched uploaded (Revision > 7) with the typo fixed. Please ignore Revision 6 of the Diff as it's a bad > upload. Please use Revision 7 as the one with the type fix. > > Thanks.
Thanks for you efforts in fixing all this things :) I shipped it. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38806/#review101515 ----------------------------------------------------------- On Oct. 5, 2015, 8:17 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38806/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 8:17 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid > Wagle. > > > Bugs: AMBARI-13242 > https://issues.apache.org/jira/browse/AMBARI-13242 > > > Repository: ambari > > > Description > ------- > > The uninstall script in RPM does not clean up the symbolic links created in > /usr/lib/python2.6/site-packages. The broken links causes following err if > user tries to install Ambari server on a node that has been previously > installed with Ambari agent. Vise Versa. > > File "/usr/sbin/ambari-server.py", line 26, in <module> > from ambari_commons.exceptions import FatalException, NonFatalException > File "/usr/lib/python2.6/site-packages/ambari_commons/_init_.py", line 21, in > <module> > File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 133, > in <module> > File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 115, > in _init_ > File "/usr/lib/python2.6/site-packages/ambari_commons/os_check.py", line 112, > in initialize_data > > > Diffs > ----- > > ambari-agent/conf/unix/install-helper.sh 35c67fb > ambari-server/conf/unix/install-helper.sh 9dbb2b8 > > Diff: https://reviews.apache.org/r/38806/diff/ > > > Testing > ------- > > Generate Ambari Server and Agent RPMs > Install the Ambari Agent RPM on a machine > Run yum erase to remove the Ambari Agent RPM > verify the symbolic links in > /usr/lib/python2.6/site-packages are removed. > On the very same machine, now install Ambari Server RPM > verify the RPM > install is successful, and can start/stop Ambari server. > Run yum erase to remove the Ambari Server RPM > verify the symbolic links in > /usr/lib/python2.6/site-packages are removed. > > > Thanks, > > Di Li > >
