-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39128/#review101899
-----------------------------------------------------------
1) Please add unit test for method.
2) I think it will be good idea to create and use method like:
/**
* This method returns Map of clusters.
* Map can be empty or with some objects,
* but never be null.
*
* @param clusters Clusters type of object.
*/
public Map<String, Cluster> getCheckedClusterMap(Clusters clusters) {
Map<String, Cluster> clusterMap = new HashMap<>();
if (clusters != null) {
if (clusters.getClusters() != null) {
clusterMap = clusters.getClusters();
}
}
return clusterMap;
}
3)method "updateAlertDefinitionEntitySource" will be better to move into
related DAO.
- Vitalyi Brodetskyi
On Жов. 8, 2015, 12:09 після полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39128/
> -----------------------------------------------------------
>
> (Updated Жов. 8, 2015, 12:09 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13355
> https://issues.apache.org/jira/browse/AMBARI-13355
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari UI is showing alert for HDFS->Journal Node Process.
> By alert definition "This host-level alert is triggered if the JournalNode
> process cannot be confirmed to be up and listening on the network."
>
> When i check on one of the journal node last successful call was made at -
> 2015-09-29 08:07:11,892
>
>
>
>
> 2015-09-29 08:07:11,892 INFO namenode.FSImage
> (FSEditLogLoader.java:loadFSEdits(145)) - Edits file
> /grid/0/hadoop/hdfs/namenode/current/edits_0000000000000002757-0000000000000002781,
>
> http://scale-test-20-nodes-part1-1.novalocal:8480/getJournal?jid=nameservice&segmentTxId=2757&storageInfo=-63%3A1242882785%3A0%3ACID-6fd83300-71b7-41e3-aa2f-c40614cae059,
>
> http://scale-test-20-nodes-part1-11.novalocal:8480/getJournal?jid=nameservice&segmentTxId=2757&storageInfo=-63%3A1242882785%3A0%3ACID-6fd83300-71b7-41e3-aa2f-c40614cae059
> of size 1048576 edits # 25 loaded in 0 seconds
>
>
> But the JournalNode process was running
>
>
>
>
> [root@scale-test-20-nodes-part1-1 hdfs]# /usr/jdk64/jdk1.7.0_67/bin/jps
> 21731
> 23257 DFSZKFailoverController
> 3220 ApplicationHistoryServer
> 25424 QuorumPeerMain
> 27350 NodeManager
> 23011
> 5427 -- process information unavailable
> 26990 ResourceManager
> 5354 Application
> 27938 Jps
> 6385 Application
> 22143 JournalNode
> 23514 NameNode
> 3176 HMaster
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java
> dcdbb85
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json
> 2ea9446
>
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java
> a54dee2
>
> Diff: https://reviews.apache.org/r/39128/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
