jun aoki created AMBARI-13362:
---------------------------------
Summary: Hadoop QA CI (aka test-patch) does not testing unit test?
Key: AMBARI-13362
URL: https://issues.apache.org/jira/browse/AMBARI-13362
Project: Ambari
Issue Type: Bug
Reporter: jun aoki
Assignee: jun aoki
Recently we had a test failure on trunk(1) after a patch (2) was applied, where
the patch was passed on Hadoop QA. (3)
The error is clearly from the patch. (4)
This was a bit of mystery because Hadoop QA should have guaranteed the patch
was OK on trunk but the patch broke it in reality.
Turn out to be this is a bug in test-patch.sh, which attempts to find out only
modified modules and test them.
(1) this trunk build failed
https://builds.apache.org/job/Ambari-trunk-Commit/3609/
(2) this is the patch Hadoop QA passed but failed on trunk
https://issues.apache.org/jira/browse/AMBARI-13156
(3) test-patch passed on the patch
https://issues.apache.org/jira/browse/AMBARI-13156?focusedCommentId=14946234&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14946234
(4) but ended up with an test failure on trunk after committed.
{code}
[0m 1) Ambari Web Unit tests test/data/HDP2.3/site_properties_test
hdp2SiteProperties Check attributes of
"hawq-site.xml/hawq_master_address_host". Stack driven attributes should be
undefined :
[0m[31m AssertionError: expected 'HAWQ Master' to equal undefined[0m[90m
at
file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/chai/chai.js:925
at assertEqual
(file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/chai/chai.js:1402)
at
file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/chai/chai.js:3638
at
file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/public/test/javascripts/test.js:39586
at
file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/mocha/mocha.js:4039
at
file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/mocha/mocha.js:4404
at
file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/mocha/mocha.js:4463
at next
(file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/mocha/mocha.js:4330)
at
file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/mocha/mocha.js:4339
at next
(file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/mocha/mocha.js:4287)
at
file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/mocha/mocha.js:4307
at timeslice
(file:///home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-web/node_modules/mocha/mocha.js:5279)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)