----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39080/#review102066 -----------------------------------------------------------
Ship it! ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java (line 118) <https://reviews.apache.org/r/39080/#comment159591> Lets make this protected with comment as test helper method. - Sid Wagle On Oct. 9, 2015, 3:46 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39080/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 3:46 p.m.) > > > Review request for Ambari and Sid Wagle. > > > Bugs: AMBARI-13336 > https://issues.apache.org/jira/browse/AMBARI-13336 > > > Repository: ambari > > > Description > ------- > > After creating a Flume agent with below configuration, I selected the host in > the agents table of Flume service summary page. I was expecting graphs of > metrics to show up for that host, but I dont see any graphs. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java > 224b490 > > ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java > 1d4c739 > > ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java > 647e026 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java > f265c4f > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java > 55b7349 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metrics.json > b0990ba > > Diff: https://reviews.apache.org/r/39080/diff/ > > > Testing > ------- > > Unit tests in progress > > > Thanks, > > Dmytro Sen > >
